Fix sdbus::ObjectPath when checking signals object_path
#1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rpm-software-management#1679 `sdbus::ObjectPath` is send over to the client not std::string. This was causing the check `signature_valid(sdbus::Signal &)` to crash, the client callback ended and the server kept waiting for result of the `key_import` userconfirm.
kontura
force-pushed
the
dnf5daemon-client-signature-valid
branch
from
5bafca1
to
30c7697
Compare
kontura
changed the title
object_pathsdbus::ObjectPath when checking signals object_path
A serialized offline transaction consists only of local packages downloaded to the `<system state dir>/offline` location. Unfortunately, PGP checks for these packages are disabled by default due to the `localpkg_gpgcheck` option default value. Instead of testing the serialized transaction, this patch performs an RPM transaction test on the originally resolved transaction, which still retains information about the repositories from which the packages were downloaded. This approach also saves time required for deserialization and resolving the testing transaction. This ports the fix from rpm-software-management#1672 to dnf5daemon.
Merged
via the queue into
rpm-software-management:main
with commit Sep 20, 2024
799a90b
20 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deserialization when checking signals
object_path.Since dnfdaemon: Correct D-Bus signal argument type #1679
sdbus::ObjectPathis send over to the client notstd::string.This was causing the check
signature_valid(sdbus::Signal &)to crash, the client callback ended and the server kept waiting for result of thekey_importuserconfirm.(I believe we should somehow handle when
DbusCallback::signature_valid()returnsfalsebut I am not sure what would be the best approach. At least logging the event would be good (through thecontext?).)The other commit fixes a bug for dnf5daemon offline transactions, analogous to dnf5: Run transaction test for offline transactions #1672.